Minor updates and improvements. #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,7 @@ | |||
| $(function () { | |||
| $.scrollUp({ | |||
| animation: 'slide', | |||
| activeOverlay: '#00FFFF' | |||
| activeOverlay: '#00FFFF', | |||
There was a problem hiding this comment.
The commas aren't really needed here and the above case.
There was a problem hiding this comment.
Who said these are required? I prefer to put comma after the last element, in case I would like to add another line. I think, I've made this (tiny) change automatically. Since it has no impact on the behavior, is this conversation needed?
There was a problem hiding this comment.
Yes, it is needed. Useless changes are useless.
There was a problem hiding this comment.
But those two commas are only a tiny part of the whole PR. Unless the author says to remove them, EOT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated bower.json to require jQuery v1.11.1
Improved clean (gulp) task and adjusted demo page.